Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing role #6460

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Editing role #6460

merged 1 commit into from
Nov 12, 2024

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Nov 12, 2024 •
edited by github-actions bot
Loading

What are you changing in this pull request and why?

Since the dbt Cloud app is not in the official Slack marketplace only Workspace Owners can install

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

🚀 Deployment available! Here are the direct links to the updated files:

@matthewshaver matthewshaver requested a review from a team as a code owner November 12, 2024 14:55
@vercel Vercel
Copy link

vercel bot commented Nov 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Nov 12, 2024 2:57pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix. labels Nov 12, 2024
nataliefiann
nataliefiann reviewed Nov 12, 2024
View reviewed changes
website/docs/docs/deploy/job-notifications.md
@@ -56,7 +56,7 @@ If there has been a change in user roles or Slack permissions where you no longe
:::

### Prerequisites
- You must be an administrator of the Slack workspace.
- You must be a Slack Workspace Owner.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @matthewshaver

This is more of a question - in the docs "workspace" isn't capitalised and "owner" is capitalised so should "Slack Workspace Owner" be "Slack workspace Owner"?

Kind Regards
Natalie

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question! We treat it the same way that Slack treats it, rather than porting it over to our style guide.

nataliefiann
nataliefiann approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @matthewshaver

I've approved this for you but left a QQ as I wasn't sure about the punctuation after reading our docs. It's a non-blocker.

Kind Regards
Natalie

@matthewshaver matthewshaver merged commit d3c7261 into current Nov 12, 2024
17 checks passed
@matthewshaver matthewshaver deleted the slack branch November 12, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliefiann nataliefiann nataliefiann approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewshaver @nataliefiann